Skip to content

feat: add url property to RequestInfo interface #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
valentinbeggi wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

feat: add url property to RequestInfo interface #1353

valentinbeggi wants to merge 1 commit into from
+36 −8

Conversation

@valentinbeggi
Copy link

@valentinbeggi valentinbeggi commented Dec 30, 2025 •
edited
Loading

Summary

  • Add optional url property to RequestInfo interface exposing the request URL
  • Enables server handlers to access query parameters and path info from incoming requests

Closes #1351

export interface RequestInfo {
    headers: IsomorphicHeaders;
    url?: string;  // e.g., "http://localhost:3000/mcp?foo=bar" or "/?sessionId=abc"
}

Note: Could type url as URL instead of string for better DX (.searchParams, .pathname, etc). However, Node.js IncomingMessage.url is a relative path (/path?query), requiring a base URL to construct. Happy to implement if preferred.

Test plan

  • Updated existing requestInfo tests to verify url property

@valentinbeggi valentinbeggi requested a review from a team as a code owner December 30, 2025 15:27
@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b8cb152

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@valentinbeggi valentinbeggi force-pushed the feat/add-url-to-request-info-v1 branch from d717684 to f385229 Compare December 30, 2025 15:28
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 30, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@1353

commit: b8cb152

@mattzcarey
Copy link
Contributor

mattzcarey commented Jan 9, 2026 •
edited
Loading

Unfortunately the node server req.url only gives the path not the base url. The web standards request.url gives the full url. atm this will have inconsistent behaviour across the different transports.

cc. @KKonstantinov

EDIT: i read the comment fully. I think I would prefer URL type and unify it across transports.

@valentinbeggi valentinbeggi force-pushed the feat/add-url-to-request-info-v1 branch from f385229 to b8cb152 Compare January 13, 2026 17:27
@valentinbeggi
Copy link
Author

valentinbeggi commented Jan 13, 2026

@mattzcarey updated ✅

@paulleseute
Copy link

paulleseute commented Feb 4, 2026

@mattzcarey Can we please merge this ? This is much needed now Claude requires the resources meta to embed an hash of the path as domain (MCP server can be served on multiple endpoints).

@mattzcarey
Copy link
Contributor

mattzcarey commented Feb 4, 2026

This is coming in v2 but maybe we should back port @felixweinberger ?

@paulleseute paulleseute mentioned this pull request Feb 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valentinbeggi @mattzcarey @paulleseute